sampler.py: Add args to specify params to optimize over + not copy full model.#102
Open
wiwu2390 wants to merge 2 commits intotimaeus-research:mainfrom
Open
sampler.py: Add args to specify params to optimize over + not copy full model.#102wiwu2390 wants to merge 2 commits intotimaeus-research:mainfrom
wiwu2390 wants to merge 2 commits intotimaeus-research:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for memory-efficient LoRA-SGMCMC (or parameter-refined SGMCMC in general).
With the existing implementation, the full model's parameters are copied at least twice: once in sample_single_chain, and another time for the localizing prior. I think the prior should never have to copy non-optimized params, while sample_single_chain should only need to do so when running on multiple GPUs.